test_proxy_connection: make test more robust #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erebe
reviewed
Dec 30, 2024
- Support running on macos with podman (this probably also fixes it to work with docker as well). This is done by using a dedicated network name and by dynamically finding the host ip. In macos, both podman & docker are running inside a Linux VM, so it is essential to find a real IP associated with the macos itself. - Run the mock TCP server on a dynamic port. This avoid flakiness in case the port is already in use.
tsnoam
force-pushed
the
test_proxy_connection
branch
from
7a6e8b0 to
394e37f
Compare
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support running on macos with podman (this probably also fixes it to work with docker as well). This is done by using a dedicated network name and by dynamically finding the host ip. In macos, both podman & docker are running inside a Linux VM, so it is essential to find a real IP associated with the macos itself.
Run the mock TCP server on a dynamic port. This avoid flakiness in case the port is already in use.